n8n icon indicating copy to clipboard operation
n8n copied to clipboard

fix: Return scopes on more resource APIs

Open valya opened this issue 10 months ago • 2 comments

Summary

The frontend needs the scopes on new workflows and credentials, so we return them.

Review / Merge checklist

  • [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • [ ] Docs updated or follow-up ticket created.
  • [x] Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.

valya avatar Apr 11 '24 14:04 valya

:warning: Some Cypress E2E specs are failing, please fix them before merging

github-actions[bot] avatar Apr 12 '24 15:04 github-actions[bot]

32 failed tests on run #4688 ↗︎

32 266 5 0 Flakiness 0

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 valya 🗃️ e2e/*
Project: n8n Commit: 1f917e2d74
Status: Failed Duration: 05:53 💡
Started: Apr 12, 2024 3:39 PM Ended: Apr 12, 2024 3:45 PM
Failed  5-ndv.cy.ts • 1 failed test

View Output Video

Test Artifacts
NDV > Stop listening for trigger event from NDV Test Replay Screenshots Video
Failed  30-editor-after-route-changes.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Editor actions should work > after switching between Editor and Debug Test Replay Screenshots Video
Editor zoom should work after route changes > after switching between Editor and Workflow history and Workflow list Test Replay Screenshots Video
Failed  2-credentials.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Credentials > should create credentials from NDV for node with multiple auth options Test Replay Screenshots Video
Credentials > should show multiple credential types in the same dropdown Test Replay Screenshots Video
Failed  30-langchain.cy.ts • 3 failed tests

View Output Video

Test Artifacts
Langchain Integration > should be able to open and execute Basic LLM Chain node Test Replay Screenshots Video
Langchain Integration > should be able to open and execute Agent node Test Replay Screenshots Video
Langchain Integration > should add and use Manual Chat Trigger node together with Agent node Test Replay Screenshots Video
Failed  19-execution.cy.ts • 4 failed tests

View Output Video

Test Artifacts
Execution > should send proper payload for node rerun Test Replay Screenshots Video
Execution > should send proper payload for manual node run Test Replay Screenshots Video
Execution > should successfully execute partial executions with nodes attached to the second output Test Replay Screenshots Video
Execution > should execute workflow partially up to the node that has issues Test Replay Screenshots Video

The first 5 failed specs are shown, see all 32 specs in Cypress Cloud.

Review all test suite changes for PR #9128 ↗︎

cypress[bot] avatar Apr 12 '24 15:04 cypress[bot]