n8n
n8n copied to clipboard
n8n-io
feat(editor): Refactor and unify executions views (no-changelog)
Summary
- Introduced executions store
- Refactored and componentized global executions view
- Refactored workflow executions view
- Extracted common executions code into executions store and implemented in views
- Progressed towards design-only components
- Restructured executions components dir
Related tickets and issues
https://linear.app/n8n/project/executions-views-refactoring-c349f70f584b/PAY
Review / Merge checklist
- [x] PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use
(no-changelog)otherwise. (conventions) - [x] Docs updated or follow-up ticket created.
- [x] Tests included.
A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests.
1 flaky test on run #4726 ↗︎
 0 |
 355 |
 12 |
 0 |
 1 |
Details:
| 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 alexgrozav 🗃️ e2e/* | |||
| Project: n8n | Commit: 00ce6b7b79 |
||
| Status: Passed | Duration: 04:18 💡 | ||
| Started: Apr 19, 2024 5:29 AM | Ended: Apr 19, 2024 5:33 AM | ||
cypress/e2e/5-ndv.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
Review all test suite changes for PR #8538 ↗︎
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
:warning: Some Cypress E2E specs are failing, please fix them before merging
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I was testing this and found 2 issues:
First one is this, where there's apparently a console log message.
The second is that I don't seem to be able to stop manual executions. This is a simple workflow with a wait for 3 minutes. I can't stop it, and the UI is not updating properly once the execution ends. Not sure if this is related to the current changes, but I thought I should mention this.
Other than this it all seems to be working fine: filtering by status, auto refresh, filtering by custom data, stopping and retrying executions.
Once the above is fixed, I think we can do one final pass to check all the open tickets about execution issues and see if they're all fixed.
:warning: Some Cypress E2E specs are failing, please fix them before merging
:warning: Some Cypress E2E specs are failing, please fix them before merging
:warning: Some Cypress E2E specs are failing, please fix them before merging
