n8n icon indicating copy to clipboard operation
n8n copied to clipboard

refactor(core): Use DI for WorkflowRunner (no-changelog)

Open netroy opened this issue 1 year ago • 3 comments

continue moving code to DI.

Review / Merge checklist

  • [x] PR title and summary are descriptive

netroy avatar Jan 17 '24 17:01 netroy

Just saw the test results 😐

krynble avatar Jan 18 '24 09:01 krynble

1 flaky test on run #3935 ↗︎

0 338 5 0 Flakiness 1

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 649134e812
Status: Passed Duration: 03:30 💡
Started: Jan 26, 2024 12:44 PM Ended: Jan 26, 2024 12:47 PM
Flakiness  cypress/e2e/5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video

Review all test suite changes for PR #8372 ↗︎

cypress[bot] avatar Jan 18 '24 09:01 cypress[bot]

:white_check_mark: All Cypress E2E specs passed

github-actions[bot] avatar Jan 18 '24 09:01 github-actions[bot]

:white_check_mark: All Cypress E2E specs passed

github-actions[bot] avatar Jan 26 '24 12:01 github-actions[bot]

Got released with [email protected]

janober avatar Feb 02 '24 13:02 janober