n8n
n8n copied to clipboard
feat(core): Add metrics for queue mode
TODO
- [ ] Fix webhooks in queue mode when not using "respond immediately"
Great PR! Please pay attention to the following items before merging:
Files matching packages/**
:
- [ ] If fixing bug, added test to cover scenario.
- [ ] If addressing forum or Github issue, added link to description.
Files matching packages/**/*.ts
:
- [ ] Added unit tests to cover new or updated functionality.
Make sure to check off this list before asking for review.
Codecov Report
Attention: 54 lines
in your changes are missing coverage. Please review.
Comparison is base (
774fe20
) 33.56% compared to head (a836534
) 33.48%.
:exclamation: Current head a836534 differs from pull request most recent head 1f8178a. Consider uploading reports for the commit 1f8178a to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## master #7263 +/- ##
==========================================
- Coverage 33.56% 33.48% -0.09%
==========================================
Files 3399 3389 -10
Lines 207458 206384 -1074
Branches 22425 22279 -146
==========================================
- Hits 69632 69102 -530
+ Misses 136698 136163 -535
+ Partials 1128 1119 -9
Files | Coverage Δ | |
---|---|---|
packages/cli/src/config/schema.ts | 81.81% <ø> (-1.52%) |
:arrow_down: |
packages/cli/src/WorkflowRunner.ts | 9.25% <0.00%> (-4.04%) |
:arrow_down: |
packages/cli/src/decorators/Debounce.ts | 50.00% <50.00%> (ø) |
|
packages/cli/src/services/metrics.service.ts | 62.50% <68.00%> (-0.66%) |
:arrow_down: |
packages/cli/src/commands/worker.ts | 26.97% <15.38%> (+0.12%) |
:arrow_up: |
packages/cli/src/Queue.ts | 17.74% <20.58%> (+4.10%) |
:arrow_up: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hello, is there plan to continue on this feature? it would help us with observability
The PR is still open so at the moment the plan would be to finish this at some point but we have no timeframe as other features / issues have a higher priority.
closing this for now, and we will create a new PR to handle multi-main support as well. tracking this internally in PAY-1462.