n8n icon indicating copy to clipboard operation
n8n copied to clipboard

feat(FileMaker Node): Add support for self signed certificates

Open Joffcom opened this issue 2 years ago • 3 comments

Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/filemaker-node-login-error/28117

Joffcom avatar Aug 04 '23 08:08 Joffcom

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • [ ] If fixing bug, added test to cover scenario.
  • [ ] If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • [ ] Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • [ ] Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

github-actions[bot] avatar Aug 04 '23 08:08 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 24.81%. Comparing base (905eef8) to head (6f78bb9). Report is 2845 commits behind head on master.

Files with missing lines Patch % Lines
...ges/nodes-base/nodes/FileMaker/GenericFunctions.ts 0.00% 6 Missing :warning:
...kages/nodes-base/nodes/FileMaker/FileMaker.node.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6851      +/-   ##
==========================================
- Coverage   24.81%   24.81%   -0.01%     
==========================================
  Files        3137     3137              
  Lines      191140   191147       +7     
  Branches    21064    21063       -1     
==========================================
- Hits        47440    47439       -1     
- Misses     142734   142742       +8     
  Partials      966      966              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 04 '23 08:08 codecov[bot]

Can we close this, and ask in the community post if they can use the custom CA cert mechanism instead ?

netroy avatar Jun 20 '24 19:06 netroy