n8n icon indicating copy to clipboard operation
n8n copied to clipboard

Allow SMTP configuration without auth

Open xavier-calland opened this issue 2 years ago • 2 comments

  • do not check for user/pass in isEmailSetUp
  • do not pass an "auth" property to nodemailer if no user/pass

Issue: #3740

xavier-calland avatar Jul 20 '22 13:07 xavier-calland

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jul 20 '22 13:07 CLAassistant

Hello, on my server there is an SMTP which does not requiere auth when reached internally (via localhost or 127.0.0.1). I think this PR could fix the issue I have (https://github.com/YunoHost-Apps/n8n_ynh/issues/30). If I try to build and test this PR, would this help?

nathanael-h avatar Sep 01 '22 07:09 nathanael-h

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • [ ] If fixing bug, added test to cover scenario.
  • [ ] If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • [ ] Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

github-actions[bot] avatar Aug 14 '23 14:08 github-actions[bot]

Codecov Report

Patch coverage: 20.00% and project coverage change: +0.01% :tada:

Comparison is base (a82107f) 24.85% compared to head (0f38e40) 24.86%. Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3742      +/-   ##
==========================================
+ Coverage   24.85%   24.86%   +0.01%     
==========================================
  Files        3144     3144              
  Lines      191241   191258      +17     
  Branches    21089    21095       +6     
==========================================
+ Hits        47528    47552      +24     
+ Misses     142735   142725      -10     
- Partials      978      981       +3     
Files Changed Coverage Δ
...ackages/cli/src/UserManagement/email/NodeMailer.ts 11.11% <0.00%> (-1.02%) :arrow_down:
...ges/cli/src/UserManagement/UserManagementHelper.ts 78.88% <100.00%> (-0.46%) :arrow_down:

... and 8 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 14 '23 15:08 codecov[bot]

Hey @xavier-calland,

Thanks for the PR and sorry for the delay, I am planning on getting this merged shortly.

Joffcom avatar Aug 14 '23 15:08 Joffcom

Got released with [email protected]

janober avatar Aug 16 '23 16:08 janober