n8n icon indicating copy to clipboard operation
n8n copied to clipboard

1SaaS v2 node release

Open wemakefuture opened this issue 2 years ago • 8 comments

wemakefuture avatar May 03 '22 13:05 wemakefuture

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar May 04 '22 09:05 CLAassistant

@CLAassistant singed it

wemakefuture avatar May 10 '22 09:05 wemakefuture

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.2 out of 3 committers have signed the CLA.✅ Pascal-Sch✅ Joffcom❌ wemakefuture

wemakefuture seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it.

https://github.com/wemakefuture @janober @Joffcom (the CLAassistant does not recognize the user) its signed please approve!

wemakefuture avatar May 10 '22 09:05 wemakefuture

Hey @wemakefuture,

Are you sure it was signed using the WeMakeFuture account? One of our internal chaps had an issue the other day where they didn't have the same email used on their Github account and once they added it they were able to sign the license agreement. I am not sure if we actually can overwrite the license agreement though as that would make it less useful.

Just to set some expectations with review timelines we are still working through older node improvements and bug fixes before working on new nodes but to make things easier we are working on a community node repository that will allow loading custom nodes in an easier way so we wouldn't be blocking anyone that wants to use the node. More information on this can be found here: https://community.n8n.io/t/community-code-contributions-and-short-term-roadmap/13545

Joffcom avatar May 10 '22 10:05 Joffcom

image

We had this in the past, the account was created via SSO and was later switched to Email based and the email was changed several times. This conflicts usually with these kind of tools. Please apporve by hand - you see we signed it. @Joffcom

wemakefuture avatar May 10 '22 16:05 wemakefuture

@Joffcom that might be for bigger customers a nightmere if a developer pushes with its account and you now need to add the developer on the main account - securitywise speaking a nightmere... Would suppose different approach. Please take this as a feedback.

wemakefuture avatar May 11 '22 09:05 wemakefuture

@Joffcom can you please update us on the status?

wemakefuture avatar Jul 16 '22 10:07 wemakefuture

Hey @wemakefuture,

We are still not into the new node PRs yet, we are however about to release our Community Node feature which will allow users to easily install nodes from NPM in the n8n interface.

Joffcom avatar Jul 16 '22 17:07 Joffcom

Hey @wemakefuture,

Thanks for the contribution, We have now created a Community Node Repository which is our preferred method for new node submissions.

Once a node has been published to the Community Node Repository users will be able to install the node from their n8n interface and will be able to use your node quicker, You will also be able to update the node as needed without needing to wait for the review process.

In the future we may reach out to you about including your node in our main release, But for now I am going to close this PR.

You can find more information in the links below, If you have any questions about this or need any help let us know.

Building Community Nodes: https://docs.n8n.io/integrations/community-nodes/build-community-nodes/ Submitting Community Nodes: https://docs.n8n.io/integrations/creating-nodes/deploy/submit-community-nodes/ Published Nodes: https://www.npmjs.com/search?q=keywords:n8n-community-node-package

Joffcom avatar Sep 08 '22 15:09 Joffcom