n8n icon indicating copy to clipboard operation
n8n copied to clipboard

[Notion] Attempt to fix Notion trigger polling strategy

Open knshiro opened this issue 3 years ago • 6 comments

There are a few complaints about the notion trigger so I thought I could try to propose something.

The existing strategy is using timings of the call in order to decide which records to process and that can be risky especially on a 1 minute poll since there could times where the poll firing doesn't happen or happen too late because of the server being too busy... Plus it was checking for the last process record id to decide if there was a need to process thing which can be really wrong in the update mode where an object can be modified at different times and should be reprocessed.

So here instead I'm using the date of the last processed record as reference and processing any record from after that time or (since Notion timestamps are only down to the minute) from the same minute but that I didn't save as processed. That may be one contentious point here: in the documentation it is explicitly said to keep the static data to a minimum and here I'm saving an array of ids which is unpredictable in terms of size so I capped it to 10.

knshiro avatar Feb 14 '22 07:02 knshiro

@knshiro really cool. Thanks for the contribution. I will have a look at this somewhere this week.

RicardoE105 avatar Feb 21 '22 01:02 RicardoE105

@RicardoE105 any news on this?

knshiro avatar Mar 27 '22 21:03 knshiro

Hello @knshiro , thank you for your contribution, I had to add some fixes as request was failing probably due to API changes

michael-radency avatar May 12 '22 17:05 michael-radency

@michael-radency thanks!

knshiro avatar May 12 '22 22:05 knshiro

Whats the ETA for this fix to be merged?

diegodiaz1256 avatar May 28 '22 20:05 diegodiaz1256

Hi, any update on this? since the problen still exist when i tried the apps

muava12 avatar Aug 03 '22 11:08 muava12

Hi team, any updates on this? I'm also facing this problem. Apparently, Notion Trigger is still not usable.

kevinqz avatar Sep 28 '22 03:09 kevinqz

@RicardoE105 Any update on this fix?

elliotmatson avatar Oct 09 '22 17:10 elliotmatson

Just picked this up again. I will do more testing this week and, if all is good, merge.

RicardoE105 avatar Oct 12 '22 22:10 RicardoE105

Is there any progress here? Really would love to be able to use polling again.

sbcatania avatar Oct 24 '22 23:10 sbcatania

@RicardoE105 @michael-radency thanks for working on this!

elliotmatson avatar Nov 09 '22 13:11 elliotmatson

Got released with [email protected]

janober avatar Nov 10 '22 17:11 janober

Thank you guys! Really appreciate it 😊

knshiro avatar Nov 10 '22 22:11 knshiro