n8n icon indicating copy to clipboard operation
n8n copied to clipboard

fix(editor): Fix opening 'Schema' view by default after opening binary nodes

Open Cadiac opened this issue 1 year ago • 4 comments

Summary

The default RunData NDV tab to open should be schema on non binary nodes, even after a binary node has been opened. If user opened a node with binary inputs the default would switch to table, and this PR changes that back to schema.

https://github.com/user-attachments/assets/7f3b168c-017c-40ff-b06c-b9378633041c

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/ADO-3220/schema-view-opening-a-ndv-with-binary-inputs-changes-the-default-view

Review / Merge checklist

  • [x] PR title and summary are descriptive. (conventions)
  • [x] Docs updated or follow-up ticket created.
  • [ ] Tests included.
  • [ ] PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

Cadiac avatar Mar 04 '25 13:03 Cadiac

Should some e2e test be added for this scenario?

Cadiac avatar Mar 04 '25 13:03 Cadiac

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Mar 04 '25 13:03 codecov[bot]

n8n    Run #9639

Run Properties:  status check passed Passed #9639  •  git commit 6a13445a8e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Cadiac 🗃️ e2e/*
Project n8n
Branch Review ado-3220-schema-view-opening-a-ndv-with-binary-inputs-changes-the
Run status status check passed Passed #9639
Run duration 04m 47s
Commit git commit 6a13445a8e: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 Cadiac 🗃️ e2e/*
Committer Jaakko Husso
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 5
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 440
View all changes introduced in this branch ↗︎

cypress[bot] avatar Mar 04 '25 13:03 cypress[bot]

:white_check_mark: All Cypress E2E specs passed

github-actions[bot] avatar Mar 04 '25 13:03 github-actions[bot]

Got released with [email protected]

janober avatar Mar 12 '25 08:03 janober