n8n icon indicating copy to clipboard operation
n8n copied to clipboard

feat(core): Comply with `NO_COLOR` in logs

Open ivov opened this issue 1 year ago • 1 comments

Summary

Make log coloring dependent on NO_COLOR in prod and dev envs. Already supported on cloud.

Related Linear tickets, Github issues, and Community forum posts

https://linear.app/n8n/issue/PAY-2262

Review / Merge checklist

  • [x] PR title and summary are descriptive. (conventions)
  • [x] Docs updated or follow-up ticket created.
  • ~~Tests included.~~
  • ~~PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)~~

ivov avatar Dec 23 '24 13:12 ivov

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/core/src/logging/logger.ts 0.00% 11 Missing and 1 partial :warning:

:loudspeaker: Thoughts on this report? Let us know!

codecov[bot] avatar Dec 23 '24 13:12 codecov[bot]

n8n    Run #8498

Run Properties:  status check passed Passed #8498  •  git commit dfa05c3c8c: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project n8n
Branch Review pay-2262-no-color-in-logs
Run status status check passed Passed #8498
Run duration 04m 48s
Commit git commit dfa05c3c8c: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Committer Iván Ovejero
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 483
View all changes introduced in this branch ↗︎

cypress[bot] avatar Dec 30 '24 12:12 cypress[bot]

:white_check_mark: All Cypress E2E specs passed

github-actions[bot] avatar Dec 30 '24 12:12 github-actions[bot]

Got released with [email protected]

janober avatar Jan 09 '25 17:01 janober

Got released with [email protected]

janober avatar Jan 09 '25 17:01 janober

Got released with [email protected]

janober avatar Jan 09 '25 17:01 janober

Got released with [email protected]

janober avatar Jan 09 '25 17:01 janober