feat&fix(Nextcloud Node): Fix broken folder sharing and user actions & New action: share file/folder via internal link

[reikjarloekl]

Summary

• fixed issue in NextCloud node: all user actions except create and all folder share actions were broken, because they wrongfully addressed the webdav endpoint
• added sharing via internal link for files and folders

Related Linear tickets, Github issues, and Community forum posts

Error when sharing: https://community.n8n.io/t/nextcloud-node-doesnt-give-a-public-link/23000

Inability to get file id (they are the basis for internal links): https://community.n8n.io/t/nextcloud-node-how-to-get-the-ids-of-folders-and-files/30903/7 https://community.n8n.io/t/add-support-in-the-http-request-node-for-the-propfind-http-method/27697

Review / Merge checklist

• [X] PR title and summary are descriptive. (conventions)
• [ ] Docs updated or follow-up ticket created.
• [ ] Tests included.
• [ ] PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

[CLAassistant]

All committers have signed the CLA.

[Joffcom]

Hey @reikjarloekl,

This looks pretty good, Don't forget to sign the CLA so we can merge this. It looks like you are trying to merge from your master branch instead of a specific one so we may have some changes for you to make that we are unable to do.

[reikjarloekl]

Hey @reikjarloekl,

This looks pretty good, Don't forget to sign the CLA so we can merge this. It looks like you are trying to merge from your master branch instead of a specific one so we may have some changes for you to make that we are unable to do.

Hey @Joffcom, I signed the CLA. Let me know if you want me to make any changes. Will use a separate branch next time. =)

[Joonas12334]

Hello! Folder sharing is also broken currently.

[reikjarloekl]

Hello! Folder sharing is also broken currently.

Yes, this PR fixes that. It is waiting to be merged currently.

[Joonas12334]

Any ETA on when it will be merged? It's quite essential to our workflow.

[Joonas12334]

up!

[Joonas12334]

up

[reikjarloekl]

Hey @Joffcom, what can we do to get this merged? Is the bottle neck with testing?

Generally, there is so much great stuff laying around in the PRs here. Maybe we need trusted/ vetted community members that can help with testing?

[reikjarloekl]

Just giving this another bump, @Joffcom. Would be great to get this merged. Nextcloud sharing is still broken.

[ShireenMissi]

Thank you so much for your contribution! 🙏 This PR has been inactive for a while, so I’m going to close it for now. If you’d like to revisit it in the future, please feel free to open a new PR based on the current codebase. We’d be happy to review it.

[Joonas12334]

I feel that closing the issue instead of fixing it is unjust to the whole n8n user base. Why such decision?

[reikjarloekl]

Thank you so much for your contribution! 🙏

This PR has been inactive for a while, so I’m going to close it for now. If you’d like to revisit it in the future, please feel free to open a new PR based on the current codebase. We’d be happy to review it.

It has been inactive because you guys failed to review and release it!

I don't know - do you actually want people to contribute? Creating and testing the fix always took me a full day.

Despite bumping it up every few weeks it never gets reviewed/ tested from your end.

Now that line of yours "we'd be happy to review it" feels like a taunt.

I will certainly not spend my time improving your product for free anymore when you cannot find the 30 minutes it would have taken to verify this fix.

[ShireenMissi]

Hi @reikjarloekl, Apologies for closing your PR without a proper review. We’re actively working on improving our review process for community contributions, but in the meantime, some older PRs had to be closed based on age.

That said, looking at your PR, it seems relevant, and I’m happy to review it. To get started, could you please merge the latest master and add tests? Once that’s done, we can proceed with a proper review.

Thank you for your patience and for contributing!

[ShireenMissi]

@cubic-dev-ai review

[cubic-dev-ai[bot]]

@cubic-dev-ai review

@ShireenMissi I've started the AI code review. It'll take a few minutes to complete.

[foxhoundv]

Wow, just over a whole year has gone by and still no resolution. This is important to businesses that need to create a folder, then share it, to be able to copy a link generated and do other stuff.