n8n
n8n copied to clipboard
feat(editor): Update `element-plus` to 2.4.3 (no-changelog)
Summary
This PR updates element-plus
dependency to 2.4.3
so we can use the append-to
attribute in Dialog component. This will be needed in order to implement new n8n grid layout where modals can appear in the content area or in body (compared to current setup where they are teleported to body by default).
There have been side side-effects to the update, so please take a look if all makes sense when reviewing:
- Looks like there is a clash with
vueUse
version which madev-on-click-outside
directive to stop working (but only in production builds). I removed it and switched to using it as a function or component. - New version of
element-plus
is usingaria
attributes differently so had to update design system snapshots accordingly - It also started using the
aria-controls
attribute which is dynamic id generated on each build and that broke some of the snapshot tests. I couldn't figure out better way so added a script that removes them from snapshots before running tests - Some e2e and unit tests were updated to work with new html
Please take a look if that makes sense and feel free to suggest a better approach here 🙏
Related Linear tickets, Github issues, and Community forum posts
Closes ADO-2365
Review / Merge checklist
- [ ] PR title and summary are descriptive. (conventions)
- [ ] Docs updated or follow-up ticket created.
- [ ] Tests included.
- [ ] PR Labeled with
release/backport
(if the PR is an urgent fix that needs to be backported)