page-assist icon indicating copy to clipboard operation
page-assist copied to clipboard

`keep_alive` should be not sent if empty.

Open rick-github opened this issue 9 months ago • 3 comments

Currently keep_alive must have a value, which is sent to the ollama server. If the server has set OLLAMA_KEEP_ALIVE, this overrides the server setting. If the keep_alive field is empty, it should not be sent as part of the API call.

rick-github avatar Feb 08 '25 10:02 rick-github

Hey, Page Assist uses LangChain. I think they are sending keep_alive if it's empty, with a default value when the field is empty.

You can set the value of OLLAMA_KEEP_ALIVE here so that all Ollama requests will always use the same default value (not empty)

Image

n4ze3m avatar Feb 08 '25 15:02 n4ze3m

Maybe page-assist needs to update its library dependencies then? I don't know how how bun works or how the langchain dependencies play out.

https://github.com/langchain-ai/langchainjs/pull/7337

rick-github avatar Feb 08 '25 16:02 rick-github

Will fix it in tomorrow's release :)

n4ze3m avatar Feb 08 '25 16:02 n4ze3m