react-native-indicators icon indicating copy to clipboard operation
react-native-indicators copied to clipboard

Published 20 hours ago • verified publisher icon n4kz

Make loops work on web

Open sertony opened this issue 5 years ago • 3 comments

Currently react-native-indicator doesn't work with react-native-web due to the fact that _startNativeLoop implementation on web is not working due to the missing NativeAnimatedModule for web: https://github.com/necolas/react-native-web/blob/a877a02beb6a2032430f83b062e173d68c40c65d/packages/react-native-web/src/vendor/react-native/Animated/NativeAnimatedHelper.js#L266

That's why the only way to make it work on web is to turn off the native driver and switch to recursive calls on JS thread: https://github.com/necolas/react-native-web/blob/a877a02beb6a2032430f83b062e173d68c40c65d/packages/react-native-web/src/vendor/react-native/Animated/AnimatedImplementation.js#L452

sertony avatar Nov 27 '20 08:11 sertony

hi @n4kz , can you please check this PR?

jamesqm avatar May 06 '21 06:05 jamesqm

@n4kz Could you merge this and/or give somebody else access to help review and pull requests by any chance?

sreuter avatar Jun 18 '21 01:06 sreuter

Hey, can we move this forward? The solution seems good, what's the hold up?

Jackman3005 avatar Feb 28 '22 03:02 Jackman3005