terraform-provider-godaddy icon indicating copy to clipboard operation
terraform-provider-godaddy copied to clipboard

Granular REST API requests to Godaddy, updating individual records only

Open jakob-northvolt opened this issue 3 years ago • 15 comments

Code is commented so should be reasonably self-explainatory.

@ records will be submitted in batch because there is no way to separate out them on a subdomain basis

Any other records with both unique type and name will be submitted individually

jakob-northvolt avatar Apr 09 '21 15:04 jakob-northvolt

@kolikons: Is this something you would mind adding to your fork to make it more easily accessible?

ilons avatar Apr 19 '21 08:04 ilons

Not sure I understand what you mean, my changes are in my fork. For example: https://github.com/jakob-northvolt/terraform-godaddy/blob/master/api/domains.go

@jakob-northvolt Yes, I'm aware of that. But since kolikons code are accessible as a provider from the registry I just thought it would make sense to merge in the changes you made on your fork.

ilons avatar Apr 20 '21 05:04 ilons

@kolikons: Is this something you would mind adding to your fork to make it more easily accessible?

https://github.com/kolikons/terraform-provider-godaddy/pull/2 if u want to fix makefile =)

kolikons avatar Apr 20 '21 11:04 kolikons

Not sure I understand what you mean, my changes are in my fork. For example: https://github.com/jakob-northvolt/terraform-godaddy/blob/master/api/domains.go

@jakob-northvolt Yes, I'm aware of that. But since kolikons code are accessible as a provider from the registry I just thought it would make sense to merge in the changes you made on your fork.

I'm sorry, I did not see first that you pinged kolikons in your comment, I thought it was aimed for me. I understand what you meant now.

jakob-northvolt avatar Apr 20 '21 18:04 jakob-northvolt

Hey @jakob-northvolt - thanks for the PR. Could you merge in the latest code from the main branch?

n3integration avatar Apr 23 '21 04:04 n3integration

Yes, np, I'll do it asap

jakob-northvolt avatar Apr 26 '21 12:04 jakob-northvolt

Gents, we started using this provider and stumbled with this issue as well. Is there an estimate for this PR to be merged? Thanks for sharing.

emanuelceballos avatar Oct 14 '21 15:10 emanuelceballos

hello @jakob-northvolt could you resolve the merge conflicts?

alvarolloret avatar Jan 09 '22 15:01 alvarolloret

Unfortunately, I don't think this PR fixes #39. The plan will still show everything changing - Terraform doesn't seem very good at figuring out when two items in a set are the same :(

domdomegg avatar Oct 27 '22 02:10 domdomegg

Without a fix for the issue mentioned - this plugin is severely limited.

sheepsy90 avatar Nov 08 '22 09:11 sheepsy90

This is a sorely needed fix.

sps-software avatar Nov 30 '22 03:11 sps-software

Any chance on getting this merged in?

maxolasersquad avatar Sep 29 '23 19:09 maxolasersquad

I guess @jakob-northvolt would have to resolve the conflicts first.

maxolasersquad avatar Sep 29 '23 19:09 maxolasersquad

Any updates on this? its really impossible to use it, almost gave up and updating manually now.

mesbahtanvir avatar Jan 01 '24 04:01 mesbahtanvir

Any updates on this? its really impossible to use it, almost gave up and updating manually now.

Facing similar issues, I've decided to re-implement provider from scratch to operate on record level.

veksh avatar Jan 03 '24 17:01 veksh