envelop
envelop copied to clipboard
Add Sentry v8 compatible integration
Just flagging that the current plugins are not compatible with Sentry v8 SDK.
Some related context:
- https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md#upgrading-from-7x-to-8x
- https://gajus.com/blog/how-to-add-sentry-tracing-to-your-node-js-app}
It looks like need to migrate from startTransaction
to startSpan
, which was deprecated in Sentry v8.
ERR TypeError: Sentry.startTransaction is not a function
at onExecute (.../node_modules/@envelop/sentry/cjs/index.js:48:35)
at .../node_modules/graphql-yoga/node_modules/@envelop/core/cjs/orchestrator.js:360:37
Related dep upgrade PR https://github.com/n1ru4l/envelop/pull/2235
Needs some manual work to get it over the line and adjust to the new APIs.
jsut created a new PR #2277, with all the tests passing. I did add a @ts-expect-error though :'(
@trixobird wonderful! Was just looking for this 👏
@benjie, @n1ru4l is there anything else needs from my side to get this PR reviewed and hopefully merged? Apologies for the newbie question