envelop icon indicating copy to clipboard operation
envelop copied to clipboard

Cannot set properties of undefined (setting 'sentryEventId')

Open Warxcell opened this issue 1 year ago • 2 comments

Issue workflow progress

Progress of the issue based on the Contributor Workflow

  • [ ] 1. The issue provides a minimal reproduction available on Stackblitz.
    • Please install the latest @envelop/* packages that you are using.
    • Please make sure the reproduction is as small as possible.
  • [ ] 2. A failing test has been provided
  • [ ] 3. A local solution has been provided
  • [ ] 4. A pull request is pending review

Describe the bug sometimes this error appears

Cannot set properties of undefined (setting 'sentryEventId')

with no stack or whatsoever.

To Reproduce Steps to reproduce the behavior:

:shrug:

Expected behavior

No error.

Environment:

  • OS:
  • NodeJS:
  • @envelop/ versions:
    • @envelop/core: 5.0.0
    • @envelop/sentry: 8.0.0

Additional context

Warxcell avatar Dec 22 '23 09:12 Warxcell

I suspect its coming from here: https://github.com/n1ru4l/envelop/blob/main/packages/plugins/sentry/src/index.ts#L107C20-L107C20

Warxcell avatar Dec 22 '23 09:12 Warxcell

Hi @Warxcell and thank you for the report!

Sorry but I'm not adding a lot here but just labeling it according to our new Contribution Guide and issue flow.

One way of pushing this forward would be to add an example of the input and the output you expect to get. Maybe even adding a failing test so we could get this into stage 2!

Thank you and sorry that this comment is not a complete solution (yet).

EmrysMyrddin avatar Dec 22 '23 14:12 EmrysMyrddin