envelop icon indicating copy to clipboard operation
envelop copied to clipboard

Refactor jit plugin

Open kamilkisiela opened this issue 3 years ago • 7 comments

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [ ] Test A
  • [ ] Test B

Test Environment:

  • OS:
  • @envelop/...:
  • NodeJS:

Checklist:

  • [ ] I have followed the CONTRIBUTING doc and the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented on my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

kamilkisiela avatar Apr 20 '22 13:04 kamilkisiela

⚠️ No Changeset found

Latest commit: c2e01c537c8d0bfe2cd9f59ffcece9f9e0cf0960

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 20 '22 13:04 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
envelop ✅ Ready (Inspect) Visit Preview May 17, 2022 at 5:28PM (UTC)

vercel[bot] avatar Apr 20 '22 13:04 vercel[bot]

The latest changes of this PR are not available as alpha, since there are no linked changesets for this PR.

theguild-bot avatar Apr 20 '22 13:04 theguild-bot

@kamilkisiela try rebasing with main and should fix K6

saihaj avatar Apr 25 '22 15:04 saihaj

@kamilkisiela Do you mind rebasing this and adding a PR description + changeset that describes the changes?

n1ru4l avatar Jul 11 '22 10:07 n1ru4l

@n1ru4l not this week

kamilkisiela avatar Jul 11 '22 10:07 kamilkisiela

Hey @ardatan. this looks great. as @n1ru4l requested, can you please rebase this and add a PR description + changeset that describes the changes to merge this?

YassinEldeeb avatar Dec 16 '22 07:12 YassinEldeeb