kept icon indicating copy to clipboard operation
kept copied to clipboard

update to react v0.14

Open lionelB opened this issue 10 years ago • 8 comments

since the API is/has changed, should we update to use last react versions ?

lionelB avatar Nov 11 '14 14:11 lionelB

should be 0.14

lionelB avatar Sep 01 '15 13:09 lionelB

Sure. Could you take care of this?

n1k0 avatar Sep 01 '15 13:09 n1k0

yup !

lionelB avatar Sep 01 '15 14:09 lionelB

I've started with my old PR (#30) but I'm stucked with test :( trying to updgrade jest and since it relies on jsdom also need io.js Sooooo I was thinking, perhap's, we can use karma ? (don't hit me)

lionelB avatar Sep 04 '15 07:09 lionelB

Nodejs 4.0 being about to be released, we can just wait so jsdom will be available. Also, I'd like to throw jest out of the window as soon as possible, before writing other tests. I'd like the project to move using mocha, chai and sinon. I know this is a big change, but much likely to be maintainable on the long term. I didn't like jest much, to say the least.

n1k0 avatar Sep 04 '15 08:09 n1k0

will try to find a version of jest that work so I can finish v0.14 refactoring and after that .... bye bye jest

2015-09-04 10:44 GMT+02:00 Nicolas Perriault [email protected]:

Nodejs 4.0 being about to be released, we can just wait so jsdom will be available. Also, I'd like to throw jest out of the window as soon as possible, before writing other tests. I'd like the project to move using mocha, chai and sinon. I know this is a big change, but much likely to be maintainable on the long term. I didn't like jest much, to say the least.

— Reply to this email directly or view it on GitHub https://github.com/n1k0/kept/issues/29#issuecomment-137680869.

lionelB avatar Sep 04 '15 16:09 lionelB

ok I will also remove jest rrr

lionelB avatar Sep 09 '15 15:09 lionelB

n1k0 avatar Sep 09 '15 15:09 n1k0