Nicolas Perriault

Results 123 comments of Nicolas Perriault

I see. Then may I suggest the `run` function received a list of arguments? It's kinda challenging to come with anything creative and affordant without any kind of interaction with...

From your latest layout prototype one might expect a prompt, so that you could pass args to the program. `run` could then receive a `List String` (or maybe just a...

Thanks :) You well deserved a review today o/

Man, this looks super good. I have to switch to other tasks so I didn't take the time to run the app locally, will do asap. Great work! Cheers

We need to allow a specifying a [maxBuffer option](https://nodejs.org/api/child_process.html#child_process_child_process_execfile_file_args_options_callback) to `execFile`. Would you want to work on a patch?

> why do we need to spawn a child process in the first place? Because we need to run a phantomjs script, which isnt based on node but on QtWebKit,...

So with 29e938919a4a967db5e218e287f28d8a8dfcc54b you can already deploy to the `gh-pages` branch by running: ``` $ npm run deploy ``` Obviously this is tied to your local git repository configuration, so...

Nice. Can someone submit a PR for this?

Could you guys create a PR for this?