Update to Backbone v1.2.3

[suprememoocow]

First off, is this project being actively maintained? It's not clear from the repo.

I've updated the Backbone Events implementation to match that of Backbone v1.2.3.

I've chosen to keep the actual backbone events implementation exactly the same (line for line) as in Backbone. This means that updating it in future will be slightly easier.

I've also switched the miniscore implementation for individual methods from lodash. While this means that the resulting output size is bigger than before (15k vs 10k), the implementation methods are better tested and better supported across a wide range of browsers.

Additionally, if the application is already using lodash and browserify or webpack, the actual lodash code will be shared between the library and the application, resulting in a smaller codesize than the current implementation.

Obviously, in order to do this, I've needed to switch to commonjs modules and to webpack to package the library. The output (.min.js) is still a UMD module however.

I'd love to hear your feedback.

[n1k0]

First off, is this project being actively maintained? It's not clear from the repo.

Well, it's working fine, so I couldn't spot a reason to update it. But I'm not much actively using the lib anymore, so that explains a lot :)

As you seem to be an active user, and I don't have much time watching for updates from the Backbone ecosystem, would you like to take over the project?

As for the patch, looks fine, but wondering if switching to webpack isn't worth bumping a major release?

[suprememoocow]

Hi sorry for the terribly slow reply!

I definitely agree that bumping the version would probably be a good idea.

I'm a little hesitant to take over the project. As you may be able to tell from my response time to this message, I'm pretty snowed under with startup responsibilities and can be quite tardy at responding to issues and PRs on GitHub. However, if you feel that you're really not interested in this project any longer, I guess I'd be happy to do it.

[n1k0]

However, if you feel that you're really not interested in this project any longer, I guess I'd be happy to do it.

It's mostly that I don't use it anymore, and am also busy on many other fronts. The project badly needs an active maintainer, ideally an active user. Really, if you feel you can be that person, I'm happy to transfer ownership to you. If you don't feel it, that's okay too; I'll file an issue for seeking a new owner.

[suprememoocow]

Please could you put out a request seeking a new owner. I'm really struggling with bandwidth, otherwise I would volunteer.

[dirkbonhomme]

I don't think there's much to maintain as long as everything works fine and the Backbone API remains the same. I'm actively using (and following) this project so feel free to make me a contributor :)

[n1k0]

I've just added you both as collaborators; handle with care. And if anybody wants me to transfer full ownership, just ask.

[suprememoocow]

@n1k0 thank you!

@dirkbonhomme would mind reviewing this PR and providing some feedback? How do you feel about switching the internals to lodash?

[dirkbonhomme]

@suprememoocow I've added a few comments but the changes look good and all tests seem to pass. There's one issue though that prevents me from merging it: where you could previously load https://github.com/suprememoocow/backbone-events-standalone/blob/backbone-1.2.3/backbone-events-standalone.js into your browser directly, this is now impossible because of Webpack. Only the minified version seems to work out of the box.

Perhaps this can be easily fixed by renaming backbone-events-standalone.js to something like backbone-events-source.js and have Webpack generate both the full version and minified one.