Nikos Karampatziakis
Nikos Karampatziakis
I have started the PR, linked above. Also added the possibility to specify `cache_implementation="offloaded"` in `GenerationConfig`
> Curious to hear @n17s thoughts. @gerbenvv - These are all valid improvements. - A static offloaded cache is a great addition. - Have you done any benchmarks? - In...
Also, I suggest starting a new issue and link/mention this issue. When my PR is merged, this issue will be closed. And edit your PR to be fixing the issue...
> I have not subclassed from StaticCache since it doesn't share any of the code with it Understood. Subclassing is mostly for making code such as `if isinstance(foo, StaticCache):` work...