vira
vira copied to clipboard
n0v1c3
VIRA-296: Fix what should be an f string to make ViraBrowse work
ViraBrowse is broken and is being set to "{server}" string cause of this issue.
By making it an f string, the issue is fixed.
@n0v1c3 do you mind looking at this pull request. It just fixes an oversight.
Sorry @anujva I have been a slow developer and away quite too much. I do not even see an issue here, I will need to merge it in on my master as my dev is simply all over the place right now. It looks like you have been using the master or at least sent this for that so that should not be an issue for you directly.
I can give it the official test and do a patch release to master for you shortly.
My local vim and I are not getting along I will take a real look today at what I have broken and still get this in for you.
@anujva, sorry for the extra delay was going through the code and found an unrelated issue with how the projects list is made. I am wrapping that up now and I will just stop myself and get this to master.
I just made another push on this branch if you want to test it. I will do my playing until I get an update that I did not break your end.
I can test it out. Thanks for taking a look at it.
Cheers, Anuj
On Sun, Dec 19, 2021 at 11:16 AM Travis Gall @.***> wrote:
I just made another push on this branch if you want to test it. I will do my playing until I get an update that I did not break your end.
— Reply to this email directly, view it on GitHub https://github.com/n0v1c3/vira/pull/78#issuecomment-997445844, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7L7LSEUAUVPM3IDMOTAOTURYVSDANCNFSM5JBM5L6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
If you have LOTS of projects then you hopefully really notice a difference in that menu and I have hopefully not broken that much for this update :-)
The CR doesn't seem to have been updated. Which branch should I use?
On Sun, Dec 19, 2021 at 11:56 AM Travis Gall @.***> wrote:
If you have LOTS of projects then you hopefully really notice a difference in that menu and I have hopefully not broken that much for this update :-)
— Reply to this email directly, view it on GitHub https://github.com/n0v1c3/vira/pull/78#issuecomment-997451441, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7L7LTN7NO2RVTIB2WH45TURY2INANCNFSM5JBM5L6Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID: @.***>
I will simply add the other pull request branch in with anything else you find so I can get them in.
I could not get a final test on that branch but it was not causing issues for my current usage. May as wall take the chance to call it done.
I experience problem with ViraBrowse and I can confirm that this PR(after sorting out the conflict) solves it (tested on master: dcf24c6)
