revanced-build-template icon indicating copy to clipboard operation
revanced-build-template copied to clipboard

Published 20 hours ago • verified publisher icon n0k0m3

Root version doesn't work

Open quyleanh opened this issue 3 years ago • 10 comments

Whenever I install root version apk, the parsing problem error is thrown.

Could you please support for root version?

quyleanh avatar Jun 28 '22 10:06 quyleanh

You need to mount the rooted apk, not install it

https://github.com/revanced/revanced-cli/blob/e1c7d1082a6946d1082c8744a1d0118c1a2263ea/src/main/kotlin/app/revanced/utils/adb/Constants.kt

Will add the guide on how to do it eventually

n0k0m3 avatar Jun 28 '22 12:06 n0k0m3

Looking forward to seeing your guide.

quyleanh avatar Jun 28 '22 14:06 quyleanh

Looking forward to seeing your guide.

do you have magisk? if so check my repo https://github.com/Lyceris-chan/revanced-builder/releases/tag/latest

you can just download and flash the module in the magisk manager and it should work just fine

Lyceris-chan avatar Jun 29 '22 11:06 Lyceris-chan

@Lyceris-chan wonderful! Thank you very much. It's much easier now.

quyleanh avatar Jun 29 '22 16:06 quyleanh

Update: for root apk I don't see a "good" (read: simple) solution for this. I can totally make a script that push and exec another script to mount the apk as root, but that'll add more steps to the current setup for root people. (while it's just adb push and adb shell it's still a little bit too many steps) @Lyceris-chan do you mind making a PR for the action that build magisk module from your repo here?

n0k0m3 avatar Jul 08 '22 17:07 n0k0m3

@n0k0m3 I think it might be better if you turn my magisk module into a template without my stuff and link it to the readme this way people can make their own module and they can make pull requests for updates and other stuff.

Lyceris-chan avatar Jul 12 '22 19:07 Lyceris-chan

@n0k0m3 how about separate the current script to 2 scripts, which supports mount for root devices?

quyleanh avatar Jul 13 '22 02:07 quyleanh

I don't have a plan for that as the idea of this repo is build and install from your own phone without a PC. Thus building a magisk module would make the most sense. I'll checkout on how to make a magisk module that replace system apps by mounting then gonna go back and work on this

n0k0m3 avatar Jul 13 '22 02:07 n0k0m3

@Lyceris-chan is it required that the unmount process must be run in post-fs-data mode?

n0k0m3 avatar Jul 13 '22 03:07 n0k0m3

@Lyceris-chan is it required that the unmount process must be run in post-fs-data mode?

just do what I said earlier

Lyceris-chan avatar Jul 14 '22 02:07 Lyceris-chan