iroh icon indicating copy to clipboard operation
iroh copied to clipboard

cli and provide tests are largely flaky

Open flub opened this issue 1 year ago • 3 comments

There are a whole bunch of flaky integration tests in the following files:

  • iroh/tests/cli.rs
  • iroh/tests/provide.rs

I suspect all of these are related to filesystem latencies. We probably need a reliable way to run sync(1)/fsync(2) on the filesystem to fix all of these.

flub avatar Jan 08 '24 10:01 flub

https://github.com/n0-computer/iroh/actions/runs/7829002247/job/21360042881?pr=2009

flub avatar Feb 08 '24 11:02 flub

Maybe we should just sprinkle shelling out to the sync(1) command around to see if this helps quickly. As ugly as it may be, we'd get these tests back. If there's an equivalent for this on Windows.

flub avatar Feb 15 '24 16:02 flub

https://github.com/n0-computer/iroh/actions/runs/7829002247/job/21360042881?pr=2009

The next time we should download the logs & upload them here. They've expired since, and they'd be really valuable actually.

matheus23 avatar Jul 05 '24 07:07 matheus23

most of these tests are no longer flaky, and grouping them all together gives us a poor view of our understanding of what's wrong with each. That being said, I'll close this and open new issue for the two remaining cli flaky tests

divagant-martian avatar Aug 06 '24 19:08 divagant-martian