Nicolas Rodriguez
Nicolas Rodriguez
I'm was able to workaround this with : ```coffee window.Fancybox.bind '[data-fancybox]', on: load: (fancybox, slide) => $(slide.$content).on "contextmenu.fb", (e) -> if e.button == 2 e.preventDefault() return true ``` but the...
ping @ctran
ping @ctran About the failing specs : there must be some leaking states somewhere. Errors now appear because of https://github.com/ctran/annotate_models/pull/787.
ping @ctran
IMHO this one is better https://github.com/ClosureTree/closure_tree/pull/338 since it's compatible with Rails 6 multi DB support.
@markusherzog can you please rebase your branch on `master`? @seuros I think it's the easiest way to handle Rails 6.1 multi DB. wdyt?
> @mceachen no. It would be awesome to have tests prepared in Docker Hi there! Now the master branch is stable can you please rebase to see if it works?...
> Checks failed. If (you) don't change the if logic and keep some redundant code test pass :) ```ruby changed = public_send(changes_method)[_ct.parent_column_name] if changed || @was_new_record _ct_persist_activerecord_state do rebuild! end...
This : ```ruby if changed || @was_new_record ... end if changed && !@was_new_record ... end ``` has nothing to do with this : ```ruby if changed if @was_new_record ... else...
The change should not break tests as we only save and restore some instance variables but it would be great to have tests to cover this case.