nel icon indicating copy to clipboard operation
nel copied to clipboard

Asynchronous transpiling fix

Open apowers313 opened this issue 5 years ago • 1 comments

Related to issue #12

Changes:

  • The previous fix would sendTask twice with asynchronous code. This adds sendTask to an else statement in _runNow so that runs in either the transpiling OR if the transpiler isn't run.
  • Uses a Promise if it exists; otherwise does the try / catch inside a polyfill. Should make the code easier to upgrade if / when bumping up to a new version of node.js; and makes it easier to read in the meantime.

apowers313 avatar Dec 05 '20 20:12 apowers313

This return should ensure sendTask is run only once. If you're really convinced this is happening, I'll try to reproduce the issue, but I need to be able to reproduce it, so that I can write a test.

n-riesco avatar Dec 05 '20 22:12 n-riesco