Noa Kallioinen comments

Results 103 comments of


                                            Noa Kallioinen

In summarise draws, a function that returns a character changes all columns to character

It seems this is also caused by the behaviour of `unlist`, which results in a vector, and when performed on a list with different types inside, will convert them all...

In summarise draws, a function that returns a character changes all columns to character

I don't think so, at least initial testing adding `recursive = FALSE` in the `unlist` calls doesn't seem to change anything

In summarise draws, a function that returns a character changes all columns to character

I think purrr::flatten always returns a list, whereas unlist will return a vector even if recursive = F if there are no nested lists ```r x = list(1, 2,3) unlist(x,...

In summarise draws, a function that returns a character changes all columns to character

I think so. I can test tomorrow. Are you thinking to copy the function over to posterior?

In summarise draws, a function that returns a character changes all columns to character

Sure, I can edit the existing PR

.args in summarise draws incompatible with summary functions without ellipses

Good points @mjskay, thanks! Another idea I just had is to extend `.args` to be a named nested list, by which one could supply additional arguments to specific summary functions,...

.args in summarise draws incompatible with summary functions without ellipses

I agree, the anonymous functions end up with much neater looking code. My current use-case is not using `summarise_draws` directly, but inside [priorsense](https://github.com/n-kall/priorsense), and I currently only support summary functions...

.args in summarise draws incompatible with summary functions without ellipses

I'm fine with deprecation of `.args` but I would prefer it not to be removed until the posterior-provided summary functions support using the weights that are in the draws (or...

.args in summarise draws incompatible with summary functions without ellipses

I'm trying to remove any usage of `.args` in my code. Currently, I have been using it to pass weights (as discussed above), but also to pass the `probs` vector...

Add convergence methods for draws objects

Making a sensible method for draws would indeed be a better option.