ytify icon indicating copy to clipboard operation
ytify copied to clipboard

Tauri2 port

Open optim77 opened this issue 10 months ago • 15 comments

A basic tauri2 design has been created that allows building applications for the operating system

I tested and built on windows I don't know how it will behave on other platforms

TODO: Implement system tray feauture

optim77 avatar Feb 20 '25 16:02 optim77

So we don't need to manage a separate branch for this? This is good news. Now we need to figure out how to run this on github workflows to produce application packages.

n-ce avatar Feb 20 '25 16:02 n-ce

https://v2.tauri.app/distribute/pipelines/github/ https://github.com/tauri-apps/tauri-action/ Currently not supporting mobile compilation, but there are some workarounds mentioned https://github.com/tauri-apps/tauri-action/issues/525 https://github.com/tauri-apps/tauri-action/pull/924

n-ce avatar Feb 20 '25 16:02 n-ce

https://github.com/optim77/ytify/pull/2 This PR also serves as a test whether new build occurs on new commit.

n-ce avatar Feb 21 '25 12:02 n-ce

From what i see on the releases it seems to be updating files on the same release tag which isn't a bad thing. We just have to change the generic release tag 'App 0.1.0' to ytify 0.7.8 to coincide with current web release.

n-ce avatar Feb 21 '25 12:02 n-ce

Great Progress! What's left:

  • System Tray Integration
  • https://github.com/tauri-apps/tauri-action/pull/924
  • Fixing Layout & Playback issues

For now users can download from here.

n-ce avatar Feb 21 '25 17:02 n-ce

Did you setup the ANDROID_RELEASE_ environment variables? Also, you have setup the mac runner for ios builds, but there are no such release packages. I think that requires some sort of apple id.

n-ce avatar Feb 23 '25 09:02 n-ce

yes,, I have set variables but still something is not working, for now I am focusing on android, ios I will embrace after it

optim77 avatar Feb 23 '25 13:02 optim77

Take a look at this: https://github.com/hrzlgnm/mdns-browser/blob/main/.github/workflows/android.yml It's a working one

n-ce avatar Feb 23 '25 13:02 n-ce

Literally back to the same problem, signing error. Can you delete the three current releases?

n-ce avatar Feb 23 '25 17:02 n-ce

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Feb 24 '25 10:02 coderabbitai[bot]

ugh it was tough but the process of building an android app goes through without errors, there is still ios left

optim77 avatar Feb 24 '25 20:02 optim77

Here's something I noticed in the Android release:

  • It is not published in v0.7.8 release
  • the universal apk size is huge
  • android media notification does not trigger on audio playback
  • continuous background playback (i.e. loading a new audio after one has played completely) does not occur

n-ce avatar Feb 25 '25 05:02 n-ce

to build an app on ios the app must be signed, the signature can only be generated on apple devices, I work on windows so I am not able to do this

optim77 avatar Mar 01 '25 12:03 optim77

to build an app on ios the app must be signed, the signature can only be generated on apple devices, I work on windows so I am not able to do this

Yeah we can skip that, theres no sideloading on iOS so it's kind of useless anyway.

n-ce avatar Mar 01 '25 12:03 n-ce

I tried in many ways to implement the tray system using tauri however it does not work, both the version in js nor in rust, it seems to me that the tray system in tauri is not well developed

optim77 avatar Mar 04 '25 21:03 optim77