watershed icon indicating copy to clipboard operation
watershed copied to clipboard

Bug report: detect and process new minima is not working

Open tgis-top opened this issue 7 years ago • 1 comments

According to the article, 'geodesic influence zone' is ignored in this implementing. This is not a problem, the pseudocode that provided in the article who`s purpose is calculating 'geodesic influence distance' is of no using.

The real problem is that detecting and processing new minima will not work under a circumstance. Here is the diagram illustrating the circumstance.

tgis-top avatar Aug 28 '18 10:08 tgis-top

Hey, thanks for raising this issue. I didn't read the paper in great detail, to be honest. My implementation was sufficient for my needs. Are you willing to take care of the implementation of the geodesic influence zone? I'm happy to review and accept any pull requests.

mzur avatar Sep 02 '18 17:09 mzur