Mohamed Hubail

Results 24 comments of Mohamed Hubail

@sheremet-va I gave it a try. See 76bd9212b4f3abecce3e4cbc5178ec00d2069348. Previous code will be removed of course. In `globTestSpecs`, the filters will be matched against the files, and if there is a...

> The general direction seems fine to me, but there are some changes that we cannot make because it would be a breaking change. One thing I shouldn't be doing...

> I guess that would work but I don't understand why you need this if you will still parse it inside, right? I Forgot to add the declaration of `FileSpec`,...

Cleaned up a bit - I'm not sure if I should update these types to `string [] | FileSpec[]` too. https://github.com/vitest-dev/vitest/blob/8f49e9e544086544f4efa4bccc1256148d560606/packages/runner/src/run.ts#L516 https://github.com/vitest-dev/vitest/blob/8f49e9e544086544f4efa4bccc1256148d560606/packages/runner/src/run.ts#L498 https://github.com/vitest-dev/vitest/blob/8f49e9e544086544f4efa4bccc1256148d560606/packages/vitest/src/runtime/runBaseTests.ts#L21 https://github.com/vitest-dev/vitest/blob/8f49e9e544086544f4efa4bccc1256148d560606/packages/vitest/src/runtime/runVmTests.ts#L25-L26 - In `interpretTaskModes`, I've renamed the...

squashed and rebased. Should be up to date with main, will check it later. For now, I've added an error `IncludeTaskLocationDisabledError`, it is ok? I'm thinking of adding a new...

@sheremet-va Should be good, if you can take a look. Thanks you!

> There are issues in CI it seems. Something with benchmarking? Aha, thought it had to do with stuff not related to me, will look into it.

For the failing build, seems like it is caused by import of `FileSpec` type. Seems like I should make this type public, am I right?

@sheremet-va should be mostly good. Build is good. Test is good, but not for windows (or sometimes macos), idk why Changed code to throw an error when a given filter...