preact-render-spy icon indicating copy to clipboard operation
preact-render-spy copied to clipboard

Is project going to support preact 10?

Open Miroshni4enko opened this issue 4 years ago • 9 comments

Miroshni4enko avatar Oct 04 '19 17:10 Miroshni4enko

Hello, I migrated preact-render-spy to Preact 10. You can take a look at https://github.com/shelacek/preact-render-spy. It's WIP and there are some corner cases where this fork behaves differently.

@gnarf, @mzgoddard can you please comment on the Preact 10 support?

shelacek avatar Oct 07 '19 21:10 shelacek

Thanks!)

Miroshni4enko avatar Nov 01 '19 10:11 Miroshni4enko

First off, thanks for this project. I'm curious as well if this project will support the latest Preact? Happy to help if it gets things moving. I see that @shelacek forked and has it working with v. 10. Would you consider putting up a PR for it @shelacek?

nickytonline avatar Jan 22 '20 23:01 nickytonline

I apologize for the late reaction.

I'd like to make a PR, but at the moment I'm not sure if it would ever be accepted. However, I quite like preact-render-spy for smaller projects over a much bigger enzyme. If there is no reaction from maintainers, maybe we can join forces elsewhere. I've also noticed some meaningful commits from @soerenvullriede2101.

shelacek avatar Apr 09 '20 21:04 shelacek

We used preact-render-spy for a small project, with the update to v10 we wanted to use Fragments, so we updated the fork of @shelacek and fixed some tests. But there are still a bunch of failing tests, especially the https://github.com/mzgoddard/preact-render-spy/blob/master/src/shared-render.test.js . It seems like the contains function etc. does not work anymore. I could create a PR for the stuff we did, but this project seems kinda abandoned.

soerenvullriede2101 avatar Apr 14 '20 17:04 soerenvullriede2101

Any update on this?

thisconnect avatar Aug 15 '20 08:08 thisconnect

I guess its dead, would recommend to switch to something else if possible. I tried to fix a few things to make it kind of work again, but it feels kinda hacky. You can find it here: https://github.com/Xan0C/preact-render-spy

PS: Im @soerenvullriede2101 this is my private account

Xan0C avatar Aug 22 '20 22:08 Xan0C

thanks for the info, FYI: I checked out a new prect-cli typescript project and it is using enzyme now.

thisconnect avatar Aug 24 '20 17:08 thisconnect

We migrated towards preact-testing-library, https://github.com/forem/forem/pull/8224

nickytonline avatar Aug 24 '20 17:08 nickytonline