hard-source-webpack-plugin icon indicating copy to clipboard operation
hard-source-webpack-plugin copied to clipboard

fix: check that frozen.build exists before trying to access it

Open conorh opened this issue 5 years ago • 7 comments

If there is a compilation where frozen.build is not generated for some reason then the check here would fail and throw an exception:

   Could not freeze FILE_NAME: Cannot read property 'hash' of undefined

Added check to see if the build exists, and then fall through to regenerate if it does not.

conorh avatar Apr 10 '19 16:04 conorh

@mzgoddard Can we have this merged?

larixer avatar Jun 28 '19 07:06 larixer

@mzgoddard Could you please, please review this PR and merge it? This problem is really a showstopper for us.

larixer avatar Sep 20 '19 16:09 larixer

Any update on merging this in?

eddieferrer avatar Mar 26 '20 21:03 eddieferrer

bump

bovas85 avatar May 03 '20 15:05 bovas85

Can anyone look at the travis tests, see why they are not passing?

elevatebart avatar Jun 09 '20 17:06 elevatebart

So the tests aren't passing because npm run lint returns errors (calls prettier --list-different ...). Running npm run lint:fix should get travis to pass, as confirmed on a branch I made from this one. I actually went back a year or so in the travis build history and not a single run has succeeded, so we could merge this as is, especially since it's been tested via use of hard-source-webpack-plugin-fixed-hashbug.

TL;DR this looks perfectly safe to merge, with or without fixing the liner errors that are already in master anyway.

ansballard avatar Aug 05 '20 01:08 ansballard

m

dazjean avatar May 14 '21 07:05 dazjean