hard-source-webpack-plugin icon indicating copy to clipboard operation
hard-source-webpack-plugin copied to clipboard

Published 20 hours ago • verified publisher icon mzgoddard

fix: return value from updateMd5CacheItem

Open mzgoddard opened this issue 7 years ago • 7 comments

Return a value so that a second call to updateMd5CacheItem on the stored promise is given the input the first call received to keep from throwing an error.

mzgoddard avatar Aug 13 '18 21:08 mzgoddard

It seems like this pull-request at least partially solves some of the issues users are having in #416, we got some reports from Next.js users too (Next.js now uses hard-source-webpack-plugin since version 7). @mzgoddard could you release this patch / is there anything I can do to help?

timneutkens avatar Sep 20 '18 12:09 timneutkens

@mzgoddard Any updates on this issue??

Update:

It already caused some UI broken in our app ...

towry avatar Jan 14 '19 08:01 towry

@mzgoddard what can we do to help? I'm blocked from using this plugin until this bug is resolved (fails every time for me - applying the fix here resolves the issue).

justrhysism avatar Jan 16 '19 04:01 justrhysism

+1

webdeb avatar Mar 01 '19 01:03 webdeb

There's a non-trivial amount of tests failing on CI, which I imagine is the cause for blocking here. If someone can fix the build that would probably unstick this PR. I don't know if @mzgoddard has any quick insights on what might be causing the test failures before anyone else dives in though?

dbalatero avatar Apr 15 '19 16:04 dbalatero

any updates on this?

fabrianibrahim avatar Jun 17 '19 05:06 fabrianibrahim

any updates?

weilinzung avatar Jul 21 '19 15:07 weilinzung