GLS

GLS copied to clipboard

Issue variable definition in Javascript version

1

Variables Abest, Bbest and Cbest. Uncaught ReferenceError: Abest is not defined at GLS (gls.js:104:34) at runGLS (gls.html?run:85:10) at loaddata (gls.html?run:78:4) at FileReader.loadHandler (read-csv.js:55:4)

avazquezgit

As discussed in https://github.com/mzechmeister/viper/issues/39#issuecomment-1409336418, it might be nice to a have options `skip_header` and `delimiter` to handle csv files. [np.genfromtxt](https://numpy.org/doc/stable/reference/generated/numpy.genfromtxt.html), called in https://github.com/mzechmeister/GLS/blob/97209080065fc53549fc9781cbdc652e3acaf2b7/python/gls.py#L178 uses these argument names (`skiprows` in [np.loadtxt](https://numpy.org/doc/stable/reference/generated/numpy.loadtxt.html))....

mzechmeister

NaN response from prob with norm lnL

3

Hi, I get a NaN response from prob here. Is the calculation in line 652/3 correct? Stefan import gls as ptpp N = 100 time = np.random.uniform(54000., 56000., N) flux...

sczesla

matlab: suggests for enhancements

1

A number of suggestions to enhance the matlab version. Most of them are inspired by the python version. - [ ] include an example (evt. with a plot) - [x]...

mzechmeister