Maxim Zaks
Maxim Zaks
@JoeLoser do we have a status on this one? From what I can tell there are some unexpected deeper language problems, my guess is it has something to do with...
Actually now I rebased the minimal reproducible example [mzaks:feature/minimal-example-of-test-crash-for-new-hasher](https://github.com/mzaks/mojo/tree/feature/minimal-example-of-test-crash-for-new-hasher) and it some times passes and some times fails the test. Seems like the order of tests is important and there...
After rebasing the [mzaks:feature/minimal-example-of-test-crash-for-new-hasher](https://github.com/mzaks/mojo/tree/feature/minimal-example-of-test-crash-for-new-hasher) on todays nightly, I see following compile error on : ``` invalid indirect call: l-value of type '$0' cannot be converted to reference of type 'H'...
> I noticed there is a private `_Hasher` trait in the stdlib now? Yeah this is some incremental work done by @gabrieldemarmiesse But his effort is also stuck on following...
> @mzaks should we close this PR in favor of your recent PRs that have landed? Yes please! I am traveling till the end of the week, I intend to...
The branch is rebased, still quite a large PR :) What I can offer is to remove Radix sort from this PR and introduce it in the next one.
> Also, can we make functions other than `sort` private (prefix by `_`)? I think they should be treated as experimental/unstable. We could maybe also keep the old implementation if...
> I left a few minor comments that I'd like to see addressed before we land this. The comments are addressed and the branch is rebased.
> One more nit. Changelog entry is not very consistent with the rest, but overall LGTM I rephrased it a bit :)
@JoeLoser I reframed the PR to be just an additive change to add sorting function for the list of comparable elements. This way we can finally merge this PR and...