FlatBuffersSchemaEditor icon indicating copy to clipboard operation
FlatBuffersSchemaEditor copied to clipboard

FlatBuffersMemoryReader leaks

Open AppsIncorporated opened this issue 7 years ago • 0 comments

In the generated FlatbuffersMemoryReader, the code reads:

    deinit {
        if let originalBuffer = originalBuffer,
            let pointer = originalBuffer.baseAddress {
            pointer.deinitialize(count: count)
        }
    }

Instead it should be:

    deinit {
        if let originalBuffer = originalBuffer,
            let pointer = originalBuffer.baseAddress {
            pointer.deallocate(capacity: count)
        }
    }

The deinitialize() method turns initialized memory into unintialized memory, it does not deallocate it.

AppsIncorporated avatar May 14 '17 18:05 AppsIncorporated