react-disqus-thread icon indicating copy to clipboard operation
react-disqus-thread copied to clipboard

Unknown props warning with React 15.2.0

Open badtant opened this issue 9 years ago • 18 comments

Warning: Unknown props `shortname`, `identifier`, `category_id`, `url`, `onNewComment` on <div> tag. Remove these props from the element. For details, see https://fb.me/react-unknown-prop
    in div (created by DisqusThread)

badtant avatar Jul 06 '16 07:07 badtant

Can confirm this error. It looks like the props for the ReactDisqusThread are getting copied onto the child <div> and this is creating validation errors.

emilyaviva avatar Jul 13 '16 18:07 emilyaviva

Have the same error

kolyasya avatar Oct 08 '16 08:10 kolyasya

+1

JimmyLv avatar Oct 14 '16 16:10 JimmyLv

+1 (

sofiia-hlyniana avatar Oct 25 '16 11:10 sofiia-hlyniana

+1

hedgehog34 avatar Dec 12 '16 09:12 hedgehog34

+1

BrunoQuaresma avatar Dec 30 '16 15:12 BrunoQuaresma

+1

PascalPixel avatar Jan 24 '17 10:01 PascalPixel

+1

juanparadox avatar Jan 29 '17 04:01 juanparadox

+1

ghalex avatar Feb 10 '17 16:02 ghalex

You can use my fork here until this original package gets updated.

theplatapi avatar Feb 15 '17 22:02 theplatapi

@mzabriskie pull

PascalPixel avatar Feb 16 '17 04:02 PascalPixel

@theplatapi that fork works great, thank you!

a8568730 avatar Feb 17 '17 05:02 a8568730

@theplatapi Perhaps this is a new issue, I am receiving the following two warnings with your fork:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

Warning: DisqusThread: React.createClass is deprecated and will be removed in version 16. Use plain JavaScript classes instead. If you're not yet ready to migrate, create-react-class is available on npm as a drop-in replacement.

This is, obviously, because your code is using React.createclass and React.PropTypes. Should be an easy fix, I can submit a pull request in a bit. I just wanted to check that this was in fact a new issue with later releases of react and not a mistake on my end. Thanks!

crw avatar May 31 '17 19:05 crw

@crw Feel free to submit a merge request to my repo.

theplatapi avatar May 31 '17 21:05 theplatapi

@theplatapi Thanks! I think I got too cocky there, it is turning out to be a bit more complicated than I initially figured. I may put up with the warnings for now.

crw avatar May 31 '17 21:05 crw

@crw @theplatapi I'll have a look at refactoring out the React.createClass jazz shortly.

emilyaviva avatar Jun 01 '17 20:06 emilyaviva

https://github.com/theplatapi/react-disqus-thread/pull/1

badtant avatar Jun 12 '17 14:06 badtant

https://github.com/theplatapi/react-disqus-thread is now updated!

badtant avatar Jun 16 '17 07:06 badtant