Mikhail Zabaluev

Results 120 comments of Mikhail Zabaluev

> Do you mean we move the `ibc-proto-compiler` to `crates/tools/ibc-proto-compiler` or `tools/ibc-proto-compiler`? To `tools/ibc-proto-compiler`. Also, all library crates would be on the same level under `crates`. The logic here is...

> Wouldn't it be better to have proto be its own repository? I'm generally against splitting crates that are tightly coupled, like handlers and ibc-proto need to be. This leads...

@dhadka [Here you are](https://github.com/mzabaluev/github-actions-playground/actions/runs/116368502) I see that the 'Post Cache cargo registry index' step in the producer job gets to write its cache first: ``` Resource Url: https://artifactcache.actions.githubusercontent.com/SwZ48ggH2fmptrBol7q4o6DwD74REZ2KvEjuDiE8Jb9dgsMc8M/_apis/artifactcache/caches/58 ``` Then...

@dhadka > If you make the `path` identical in both, you should see it behave as expected. On Linux and Mac it does, on Windows it doesn't: https://github.com/mzabaluev/github-actions-playground/actions/runs/116588403 I'm guessing...

For more fun with cache key normalization across OSes, see https://github.com/actions/runner/issues/498

Any updates on this? I'm trying to decide which `actions/cache` version is a less buggy fit for our needs, between this and v1 somehow [failing](https://github.com/input-output-hk/chain-libs/runs/730161000?check_suite_focus=true) to hit the primary key...

@dhadka No, the issue reproduced in that [test run](https://github.com/mzabaluev/github-actions-playground/actions/runs/116588403) is not about `hashFiles` – the hashed file is actually ~passed as an artefact from a Linux job~ fixed up specificaly...

> The version hash [includes the compression method](https://github.com/actions/toolkit/blob/9ba7c679ad74f6a80017feeb94b7a7c19b590796/packages/cache/src/internal/cacheHttpClient.ts#L94), but we [fall back to using Gzip instead of Zstd on Windows](https://github.com/actions/toolkit/blob/9ba7c679ad74f6a80017feeb94b7a7c19b590796/packages/cache/src/internal/cacheUtils.ts#L86) due to bug #301. I hope in the end state...

Yes, we still need tar in the cache action to be fixed.

The new examples at work: https://github.com/mzabaluev/github-actions-playground/tree/cargo-bin-example https://github.com/mzabaluev/github-actions-playground/tree/cargo-lib-example