lib60870 icon indicating copy to clipboard operation
lib60870 copied to clipboard

function: CS104_Slave_startThreadless() may has a bug in it

Open tangkai-prc opened this issue 3 years ago • 1 comments

when #if (CONFIG_USE_THREADS == 1) self->isThreadlessMode = true; #endif is this a clerical error when USE_THREADS == 1? I think it is be better return when CONFIG_USE_THREADS == 1 as below: #if (CONFIG_USE_THREADS == 1) self->isThreadlessMode = false; self->isStarting = false; return ; #endif

tangkai-prc avatar Apr 30 '21 07:04 tangkai-prc

The idea is that when compiling the library with thread support (CONFIG_USE_THREADS) it is still possible using it without the library creating its own threads. Not sure if there are many use cases for this.

mzillgith avatar May 03 '21 16:05 mzillgith