Myungwoo Chun
Myungwoo Chun
If the parameter string is written in Regular Expression. We need additional check more than checking string itself.
Review status: 0 of 4 files reviewed at latest revision, 1 unresolved discussion. --- *[cms/server/contest/handlers/communication.py, line 56 at r2](https://reviewable.io:443/reviews/cms-dev/cms/788#-KqQVqqVe0tIMPEVhAby:-KqQVqqVe0tIMPEVhAbz:bkpssfu) ([raw file](https://github.com/cms-dev/cms/blob/f861b1cf58853d221867be7d04f4e39c78313f93/cms/server/contest/handlers/communication.py#L56)):* > ```Python > @multi_contest > def get(self): > #...
Sorry for the late reply. The only case I thought was the yes/no problem which @stefano-maggiolo mentioned. The solution of the problem is adding a new pre-compiled answer like "Do...
Okay, it sounds good. So a new set of precompiled answers would be add to master branch? or just for local change? The latter means no change for this topic,...
Sorry for the late reply. It was a very busy week to me. Actually, I don't get the new solution. Could you tell me more specifically? (Sorry about my bad...
Thank you for your kind reply :) I have an additional question to take my confusion away. Does "is_reply_subject_canned" work same as "is_reply_translated"?
Is the situation you meant because of language which doesnt support translating precompiled answer? Thank you!
Okay. I'll work and update PR with this. What is the best variable name of this option? is_reply_subject_canned or is_reply_can_be_translated? I prefer the latter one.
Actually precompiled answer always has no content but only subject. Reply with custom sentence has no subject but only content. So subject translatable may cause confusion to contest admin. How...
I've updated the PR. Please check and comment. Thank you very much!