Michael Cooper

Results 75 comments of Michael Cooper

> I'm not sure if it matters for v3 but with ?status=enabled isn't that part of the "hot path"? This view is not on the hot path, since most of...

Would it make sense to remove the fields from the API, so we don't get any new recipes with these fields set?

The recipe that triggered this is https://stage-admin.normandy.nonprod.cloudops.mozgcp.net/api/v3/recipe/741/ Notably, the field `recipe.arguments['name']` is `!@#*()`, which is likely what is triggering this.

> Uh? So there are still some that come in an populate the database for the many-to-many tables? I.e. stuff that goes against that big data migration when filter_object_json was...

I found the root cause of this. Recipe 741 was once a preference experiment, and is now an add-on experiment. The latest version of the recipe is an add-on experiment,...

I took a stab at this in #1943, and I've decided it is not actually a `good-first-bug`.

Yes, was the problem. Specifically, the problem was changing to a different action type that had incompatible argument schemas. This combined with another problem where some code confuses `Recipe.latest_revision` and...

There is definitely a problem related to confusion between `latest_revision` and `approved_revision` that this code exposed. In general, the properties on the `Recipe` class that tranparently pass through to *some*...

This will require changes to the normandy client. See [bug 1435879](https://bugzilla.mozilla.org/show_bug.cgi?id=1435879) for that part of the work.

Something like this? https://normandy.cdn.mozilla.net/api/docs/?format=openapi . These are machine generated from the code via Swagger. They could probably use some work, but they seem to be fairly complete to me. One...