Regression when using image links between version 3.22.0 -> 3.23.0

[Dreglor]

I've run into a recent issue after pulling the latest (3.23.1) nuget where image links do not correctly form correct markdown anymore. I was able to isolate the problem to a test and compare versions.

[Fact]
public void ImageLinkTest()
{
    var converter = new Converter();
    var result = converter.Convert("<a href=\"/link\"><img src=\"/image.jpg\" alt=\"photo\"/></a>");
    Assert.Equal("[![photo](/image.jpg)](/link)", result); // "/link" is reported in version 3.23.0
}

[mysticmind]

@Dreglor thanks for reporting this, will check and keep you updated.

[jerriep]

@mysticmind Any feedback on this one?

It seems related to the fix in https://github.com/mysticmind/reversemarkdown-net/issues/154 where you explicitly don't allow images inside anchor tags. I cannot quite figure out the reason for that as it seems completely valid to have an image inside an anchor tag (see https://github.com/mysticmind/reversemarkdown-net/blob/90e97bbd92e059c45e219eed373b6666e3779c1e/src/ReverseMarkdown/Converters/Img.cs#L14-L17)

[mysticmind]

I will revert to you on this tomorrow.

[mysticmind]

@jerriep I have checked and observing this as a regression, will release a fix shortly.

[jerriep]

@mysticmind Thank you so much. Please let me know when the new NuGet is available.

BTW, I tried to show my support to you on Ko-Fo but I got an error message "This account isn't enabled to make cross border transactions. You can enable your account at https://dashboard.stripe.com/settings/update". Are you aware of this issue?

[mysticmind]

I am trying to do few more bug fixes, will do a release later today in few hours.

Thanks and appreciate your kind support, I have updated the settings, you could retry using ko-fi or also try GitHub sponsor.

On Thu, 18 May 2023 at 5:42 AM, jerriep @.***> wrote:

@mysticmind https://github.com/mysticmind Thank you so much. Please let me know when the new NuGet is available.

BTW, I tried to show my support to you on Ko-Fo but I got an error message "This account isn't enabled to make cross border transactions. You can enable your account at https://dashboard.stripe.com/settings/update". Are you aware of this issue?

— Reply to this email directly, view it on GitHub https://github.com/mysticmind/reversemarkdown-net/issues/291#issuecomment-1552238751, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAV3IUCUKPFTHM5NNJPPITLXGVSP7ANCNFSM5WYP22ZQ . You are receiving this because you were mentioned.Message ID: @.***>

[mysticmind]

Fixed via fca907de85994abd82b6502fa0699aafc57124e5

[mysticmind]

I am trying to do few more big fixes, will do a release later today in few hours. Thanks and appreciate your kind support, I have updated the settings, you could retry using ko-fi or also try GitHub sponsor. … On Thu, 18 May 2023 at 5:42 AM, jerriep @.> wrote: @mysticmind https://github.com/mysticmind Thank you so much. Please let me know when the new NuGet is available. BTW, I tried to show my support to you on Ko-Fo but I got an error message "This account isn't enabled to make cross border transactions. You can enable your account at https://dashboard.stripe.com/settings/update". Are you aware of this issue? — Reply to this email directly, view it on GitHub <#291 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAV3IUCUKPFTHM5NNJPPITLXGVSP7ANCNFSM5WYP22ZQ . You are receiving this because you were mentioned.Message ID: @.>

@jerriep I have released 3.25.0 and it is available in NuGet.

[jerriep]

@mysticmind Thank you Babu. I tested the new version, and it works great!

BTW, KoFi now gives a new error (see below), so I donated GH sponsors instead

As per Indian regulations, export transactions require a description. More info here: https://stripe.com/docs/india-exports

[mysticmind]

Thank you so much @jerriep, appreciate your sponsor via GH. Also thanks for the heads up on ko-fi issue, I thought to have fixed based on the error but it still isn't, will check.