eslint-plugin icon indicating copy to clipboard operation
eslint-plugin copied to clipboard

Option to Also Detect Potentially Useless Shallow Clone in no-useless-rest-spread

Open FlorianWendelborn opened this issue 5 years ago • 1 comments

Please describe what the rule should do:

  1. Prevent useless rest/spread
  2. Prevent using an implicit shallow clone when a deep clone would be more appropriate and more explicit

What category of rule is this? (place an "X" next to just one item)

[ ] Enforces code style [x] Warns about a potential error [ ] Suggests an alternate way of doing something [ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

// bad

const options = {
	params: { ...payload }
)

// good


const options = {
	params: payload
)

const options = {
	params: cloneDeep(payload)
)

Why should this rule be included in ESLint-plugin (instead of a Eslint)?

N/A it’s an addition to @mysticatea/no-useless-rest-spread

FlorianWendelborn avatar Aug 21 '20 17:08 FlorianWendelborn

Hi @FlorianWendelborn!

Since this repo is unmaintained, you might want to re-open this issue in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-mysticatea

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

MichaelDeBoey avatar Oct 14 '23 15:10 MichaelDeBoey