feat: support ESLint 7.x

[MichaelDeBoey]

trafficstars

ESLint v7.0.0 is released 🎉

Dependencies should be compatible with ESLint 7 too before we can merge this one:

• [x] @typescript-eslint/eslint-plugin (https://github.com/typescript-eslint/typescript-eslint/issues/1550)
  • [x] v3.0.0
• [x] @typescript-eslint/parser (https://github.com/typescript-eslint/typescript-eslint/issues/1550)
  • [x] v3.0.0
• [x] eslint-plugin-eslint-comments (https://github.com/mysticatea/eslint-plugin-eslint-comments/issues/38)
  • [x] https://github.com/mysticatea/eslint-plugin-eslint-comments/commit/843f337
  • [x] ~Release~
• [x] eslint-plugin-eslint-plugin (https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/issues/94)
  • [x] https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/92
  • [x] https://github.com/not-an-aardvark/eslint-plugin-eslint-plugin/pull/95
  • [x] v3.0.0
• [ ] eslint-plugin-node (https://github.com/mysticatea/eslint-plugin-node/issues/223)
  • [ ] https://github.com/mysticatea/eslint-plugin-node/pull/224
  • [ ] Release
• [x] eslint-plugin-prettier (https://github.com/prettier/eslint-plugin-prettier/issues/292)
  • [x] https://github.com/prettier/eslint-plugin-prettier/issues/291
  • [x] ~Release~
• [x] eslint-plugin-vue
  • [x] https://github.com/vuejs/eslint-plugin-vue/pull/1077
  • [x] v7.0.0

---

Closes #28

This branch is dependent on #37, #38, #39, #40, #41, #42 & #43

[dimitropoulos]

I'll note that typescript-eslint just released 3.0.0 with eslint 7 support

https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0

[eddiemonge]

@MichaelDeBoey there is a circular dependency of waiting here:

• eslint-plugin-eslint-plugin is waiting for eslint-plugin-node
• This is also directly waiting on eslint-plugin-node

eslint-plugin-node, however is waiting for eslint-utils which is waiting for this PR.

This will never be completed according to that logic

[MichaelDeBoey]

@eddiemonge The circular dependency will be resolved once eslint-utils is merged without updating @mysticatea/eslint-plugin, like I explained in https://github.com/mysticatea/eslint-utils/pull/7#issuecomment-651940524 🙂

[MichaelDeBoey]

@mysticatea Tests are failing because rules are missing in configs.

I'll add them, but I think it would be good if you check them out in order to make sure it's the correct config.

[MichaelDeBoey]

@voxpelli I've merged #37, #38, #39, #40, #41, #42 & #43 and added one last commit to support ESLint v7.x

[eyedean]

@mysticatea @graingert @brettz9 any chance to get this approved?

Eslint4b (eslint in browser) with eslint v8 is pending this one.

Thanks for your time and support in advance!

[brettz9]

@eyedean : I do not have access to this library, but I have forked this project to @brettz9/eslint-plugin so as to extract the rules without all of the extra config if that might meet your needs (and it supports ESLint 8): https://github.com/brettz9/eslint-plugin

[MichaelDeBoey]

@brettz9 That still wouldn't help out eslint4b, which is of the same creator as this package.

[graingert]

@eyedean I don't have access to this repo either

[voxpelli]

Another case where an eslint-community GitHub org or such would be great, the same as for https://github.com/weiran-zsd/eslint-plugin-node/issues/8 which me, @MichaelDeBoey and @aladdin-add briefly discussed with @nzakas.

@brettz9 You've heard something more on setting such a one up? Would eg. help us in StandardJS as well

[brettz9]

Another case where an eslint-community GitHub org or such would be great, the same as for weiran-zsd/eslint-plugin-node#8 which me, @MichaelDeBoey and @aladdin-add briefly discussed with @nzakas.

@brettz9 You've heard something more on setting such a one up? Would eg. help us in StandardJS as well

I'm not aware of anything with the blessing on the ESLint side (I know the ESLint org itself is wary of taking on projects for maintainability), but I figure we can get together those already active in the community in an informal GitHub/npm organization if you think that would do the trick.

I set up https://github.com/es-joy/ a while back as a possible place for projects others might want to help maintain. Though it's more generic to JavaScript than an ESLint project, I'd be happy to send invites to yourself and those you mentioned. Alternatively I wouldn't imagine there'd be any objections to an ESLint-specific community effort being organized informally under an organization by such as yourself.

[voxpelli]

@brettz9 @es-joy sounds like a good idea 👍

I got a bit trigger happy and opened a discussion about this in the ESLint repo with some more context: https://github.com/eslint/eslint/discussions/15929

Coordinate there?

[aladdin-add]

the thoughts behind @eslint-community is not the eslint team to maintain these projects. It is to help the important projects being well-maintained. e.g. find maintainers.

[eyedean]

The idea of having a structured community and gathering good ES/ESLint projects under one umbrella is great! I am sure that's gonna attract more people (both users and volunteers/maintainers.)

@MichaelDeBoey, I think the main reason that this PR is looking huge is that you have added a .prettierrc which has changed a lot of formatting and indentations. Is it possible to take that part out as a separate PR, and let this one only serve the "actual" changes? Thanks!

[MichaelDeBoey]

@eyedean That's exactly why I've created #34, #36, #37, #38, #39, #40, #41, #42 & #43

[voxpelli]

For reference: There is an RFC up about an @eslint-community now: https://github.com/eslint/rfcs/pull/91

That seems to me like the most promising way forward for this module. Go there and add your thoughts and/or volunteer.

[MichaelDeBoey]

For people watching this PR: we've already started with our own fork in order to not hold the wider community back anymore: https://github.com/eslint-community/eslint-plugin-mysticatea

@mysticatea We would still love to move the original repo to the new https://github.com/eslint-community though.

---

This PR is released in @eslint-community/eslint-plugin-mysticatea v15.1.0 https://github.com/eslint-community/eslint-plugin-mysticatea/releases/tag/v15.1.0

[dimitropoulos]

too bad it had to come to that, but thank you for putting in the effort to get this unblocked!

I'm sure Toru is just busy. Only so many hours in the day :)

[MichaelDeBoey]

@dimitropoulos Yeah we still would like to move the original repo to the new @eslint-community org & merge all changes here

I respect @mysticatea is busy, but he hasn't responded to any of our messages in a very long time & we don't want to hold back the wider community anymore, so that's why we already started with our own fork. Once the original repo is moved, we'd be happy to take the time to merge all pending PRs & release them of course