eslint-plugin-node icon indicating copy to clipboard operation
eslint-plugin-node copied to clipboard

Published 20 hours ago • verified publisher icon mysticatea

chore(CI): add tests for ESLint 7

Open MichaelDeBoey opened this issue 4 years ago • 10 comments

ESLint v7.0.0 is released 🎉

Dependencies should be compatible with ESLint 7 too before we can merge this one:

  • [x] eslint-plugin-es (https://github.com/mysticatea/eslint-plugin-es/issues/29)
    • [x] https://github.com/mysticatea/eslint-plugin-es/pull/30
    • [x] v3.0.1
  • [x] eslint-utils (https://github.com/mysticatea/eslint-utils/issues/6)
    • [x] https://github.com/mysticatea/eslint-utils/pull/7
    • [x] v3.0.0

devDependency compatibility with ESLint 7:

  • [ ] @mysticatea/eslint-plugin (https://github.com/mysticatea/eslint-plugin/issues/28)
    • [ ] https://github.com/mysticatea/eslint-plugin/pull/29
    • [ ] Release

Closes #223

This branch is dependent on #305, #306, #307, #308 & #309

MichaelDeBoey avatar May 08 '20 22:05 MichaelDeBoey

Any plans to progress this feature/pull request?

weyert avatar Jun 22 '20 10:06 weyert

@weyert We still have to wait for mysticatea/eslint-utils#7 before we can start going forward with this one 🙂

MichaelDeBoey avatar Jun 22 '20 11:06 MichaelDeBoey

Since all tests are green for ESLint 7.x, I think we can merge this one without https://github.com/mysticatea/eslint-utils/pull/7 being merged 🙂

MichaelDeBoey avatar Sep 20 '20 13:09 MichaelDeBoey

Howdy! any plans for merging this PR? I see it was ready to be merged 22 days ago

pragmaticivan avatar Oct 12 '20 16:10 pragmaticivan

@mysticatea All tests are green (locally), so I think we can merge this one 🙂

CC/ @sosukesuzuki @ota-meshi

MichaelDeBoey avatar Jun 09 '21 10:06 MichaelDeBoey

Would it be possible to drop this down from a daunting 42 file change to something more narrowed and easier to review?

Looks like most of the diff is to sort object definitions by key and to eg. restructure the way that the CI setup is done? (Moving from an exclude to an include)

To really make reviewing and merging simpler, keeping the diff to a minimal is good 👍

voxpelli avatar Oct 14 '21 19:10 voxpelli

@voxpelli Most of the changes are due to updating @mysticatea/eslint-plugin.

Would it help if I created separate commits in order to understand a bit better what's happening?

MichaelDeBoey avatar Nov 30 '21 09:11 MichaelDeBoey

The smaller chunks the easier to review and to understand the scope, so yes, one PR per such scope would be nice 👍

voxpelli avatar Nov 30 '21 10:11 voxpelli

@voxpelli As I said before: doing everything in separate PRs won't be possible, as of the breaking changes

But I can create separate commits if that makes it easier for you

MichaelDeBoey avatar Nov 30 '21 10:11 MichaelDeBoey

@voxpelli I've merged #305, #306, #307, #308 & #309 and added one last commit to support ESLint v7.x

MichaelDeBoey avatar Nov 30 '21 18:11 MichaelDeBoey