eslint-plugin-eslint-comments icon indicating copy to clipboard operation
eslint-plugin-eslint-comments copied to clipboard

`no-unused-disable` doesn't work with flat config

Open teppeis opened this issue 1 year ago • 3 comments

This rule is implemented by patching Linter, which seems to be causing this problem with new flat config.

The flat config allows reportUnusedDisableDirectives to be included in shareable config. The new RFC will also allow for more configuration flexibility (in ESLint v9 ?).

  • https://github.com/eslint/rfcs/pull/100

So it would be good to make this rule deprecated in the future.

teppeis avatar Sep 16 '23 13:09 teppeis

Hi @teppeis!

Since this repo is unmaintained, you might want to re-open this issue in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

MichaelDeBoey avatar Oct 14 '23 15:10 MichaelDeBoey

@MichaelDeBoey I've reopened there: https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/133 thank you!

teppeis avatar Oct 16 '23 15:10 teppeis

@MichaelDeBoey if this repo is unmaintained, shouldn't it be updated / marked as unmaintained in the README and potentially archived? @mysticatea that might help avoid confusion if you're not intending to work on this plugin anymore.

IanVS avatar Mar 05 '24 16:03 IanVS