eslint-plugin-eslint-comments icon indicating copy to clipboard operation
eslint-plugin-eslint-comments copied to clipboard

require-description: previous line comment check

Open JasonMore opened this issue 4 years ago • 7 comments

I figured I'd give multi line comments for require-description a try. It seems to work?

JasonMore avatar Feb 08 '21 21:02 JasonMore

@mysticatea any thoughts on this PR?

JasonMore avatar Feb 15 '21 18:02 JasonMore

@mysticatea we have been using this a few months now with great successs

JasonMore avatar Apr 29 '21 22:04 JasonMore

@mysticatea Any chance that this gets merged? This would be really very helpful 😊

And, @JasonMore: Thanks for your work, and for submitting a PR 🎉

goloroden avatar May 17 '21 10:05 goloroden

@goloroden yeah I've just been running a local version of this myself. However I've recently discovered https://www.npmjs.com/package/patch-package which is nice too

JasonMore avatar May 20 '21 20:05 JasonMore

@JasonMore Thanks for the hint 😊

Nevertheless, it would be great if this could be merged. @mysticatea Is there anything one can do to help?

goloroden avatar May 21 '21 06:05 goloroden

@mysticatea any updates?

bossley9 avatar Mar 17 '22 16:03 bossley9

Would love to get this merged too, I have written a standalone plugin for this that we are using at the moment but feels like the functionality should live here

ehellman avatar May 25 '22 18:05 ehellman

Comments on different lines can be moved around by prettier or other eslint rules. The only way to guarantee you tie your description to your eslint comment is by using -- to include the comment on the same line.

tylerlaprade avatar Feb 24 '23 18:02 tylerlaprade

Hi @JasonMore!

Since this repo is unmaintained, you might want to re-open this PR in the @eslint-community fork https://github.com/eslint-community/eslint-plugin-eslint-comments

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

MichaelDeBoey avatar Oct 14 '23 15:10 MichaelDeBoey