Toru Nagashima

Results 120 comments of Toru Nagashima

It looks like a bug to me. I guess escope should use `this.currentScope().variableScope` instead of `this.currentScope()` at this line: https://github.com/estools/escope/blob/master/src/referencer.js#L292

Ah, there is a comment above the line...

Thank you for elaborating! I learned that this is correct behavior, so likely I need the three steps for fresh importing: ```js // Find the main file of the package...

Repro: https://eslint.org/demo#eyJ0ZXh0IjoiLyplc2xpbnQgbm8tZXh0cmEtcGFyZW5zOiBbZXJyb3IsIGFsbCwgeyBlbmZvcmNlRm9yU2VxdWVuY2VFeHByZXNzaW9uczogdHJ1ZSB9XSAqL1xuXG4vL+KclCBHT09EXG5pZiAoKGEsIGIpKSB7fVxuIiwib3B0aW9ucyI6eyJwYXJzZXJPcHRpb25zIjp7ImVjbWFWZXJzaW9uIjo4LCJzb3VyY2VUeXBlIjoibW9kdWxlIiwiZWNtYUZlYXR1cmVzIjp7fX0sInJ1bGVzIjp7fSwiZW52Ijp7fX19 I have reproduced it on Chrome 76, Firefox 69, and Edge 44.

Everyone is thinking the same thing :D I was also thinking it. Though I'm very busy recently....

Sounds nice idea. But I'm worried about AST node types. Each third-party parser has additional nodes. If this package has AST types, does it cause type errors about the additional...

Thank you so much!! I agree with you, the friendly response is better. Additionally, I'm gladder if it's easy to search by the issue status. It was the reason that...

https://github.com/eslint/eslint/blob/278813a6e759f6b5512ac64c7530c9c51732e692/lib/cli-engine/file-enumerator.js#L398 The `pattern` variable value seems to be an absolute path. The file enumerator intended to start traversing from the outermost non-pattern place. For example, if `src/**/*.js` is present, it...

`eslint-plugin-node` is an old version which does not include those rules. ``` { filePath: '', messages: [ { ruleId: 'node/no-extraneous-import', severity: 2, message: 'Definition for rule \'node/no-extraneous-import\' was not found',...

@julien-f It's a good idea. But if users use AMD's `require` or customized lookup algorithm, it might make false positive.