yournextrepresentative icon indicating copy to clipboard operation
yournextrepresentative copied to clipboard

Improving the Review page

Open JeniT opened this issue 8 years ago • 4 comments

There are several things that would improve the usability of the Review page:

  • [ ] Auto-check 'Add new person' when there are no alternatives
  • [ ] Link the radio buttons and their labels so that you can click on the labels to check the radio button
  • [ ] Remove the 'as standing in "[code for post]"' part of the label because it's just noise
  • [ ] For each possible matching person, provide a list of other posts they have stood for, so it's easier to immediately dismiss matches

Every fix like this speeds things up :) Thank you!

JeniT avatar Apr 16 '16 06:04 JeniT

Just to link these, there's another small requested improvement to the bulk adding review page here: https://github.com/mysociety/yournextrepresentative/issues/827 (show Party for suggested name matches)

mhl avatar Apr 16 '16 12:04 mhl

Agree with the first, it's in #840. Second isn't straightforward imho as some labels already contain a link. Agree with the third - I'd prefer to see which party they previously stood for. Agree with the fourth too, but to save screen space and maintain the existing layout I'd suggest text eg "previously stood in/for" linking to a tool-tip or pop-up window that contains their previous candidacies.

jf1 avatar Apr 16 '16 12:04 jf1

See the point re the second, but at least the 'Add new person' version (which doesn't contain a link) could be clickable. With the others, the text could not contain links and you could have a separate "See more >>" link after the label.

JeniT avatar Apr 16 '16 12:04 JeniT

re point 2: there is already a "for" attribute on the label which should allow this to work, it just has the wrong ID:

<label for="id_form-0-select_person"> // should be "id_form-0-select_person_4"
    <input id="id_form-0-select_person_4" name="form-0-select_person" value="7814" type="radio">
    Mark <a href="/person/7814" target="_blank">Jonathan Smith</a> as standing in "local.city-of-london.2017-03-23: LBW:E05009305"
</label>

sjorford avatar Mar 06 '17 17:03 sjorford